Skip to content

Conversation

@iromli
Copy link
Contributor

@iromli iromli commented Nov 18, 2025

Sync admin-ui resource scope mapping into OCI images.

Closes #2454

Summary by CodeRabbit

  • Chores
    • Updated internal build dependencies to latest versions
    • Optimized Docker build workflow for improved efficiency and cleaner asset management

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli self-assigned this Nov 18, 2025
@iromli iromli requested a review from moabu as a code owner November 18, 2025 22:08
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 18, 2025

📝 Walkthrough

Walkthrough

Version pins for JANS and FLEX sources are updated in docker-admin-ui. The docker-flex-all-in-one build workflow is refactored to perform direct cloning and sparse-checkout with explicit WORKDIR management instead of nested /tmp/jans directory operations, with JANS source version also updated.

Changes

Cohort / File(s) Change Summary
Admin UI Version Updates
docker-admin-ui/Dockerfile
Updated JANS_SOURCE_VERSION to 88d8e89acc598b9ddf68659b0a51c3c9e3b712f0 and FLEX_SOURCE_VERSION to 7dd724e for resource scope mapping sync.
Flex All-in-One Build Refactoring
docker-flex-all-in-one/Dockerfile
Refactored clone workflow to use sparse-checkout with direct cloning into current directory and explicit WORKDIR changes (/tmp/jans → . → checkout → root). Updated JANS_SOURCE_VERSION to 88d8e89acc598b9ddf68659b0a51c3c9e3b712f0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Note: Focus on verifying the new WORKDIR management sequence in docker-flex-all-in-one, particularly that sparse-checkout and version checkout operations occur in the correct directory context before returning to root.

Possibly related PRs

Suggested labels

comp-admin-ui, comp-docker-admin-ui

Suggested reviewers

  • moabu

Poem

🐰 Docker images dance with glee,
Version pins updated, clean and free,
Sparse-checkout flows from root so true,
JANS and FLEX, refreshed anew! 🐳

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'sync admin-ui resource scope mapping' accurately reflects the main objective of updating admin-ui image templates to synchronize resource scope mapping changes.
Linked Issues check ✅ Passed The PR updates JANS_SOURCE_VERSION and FLEX_SOURCE_VERSION commit hashes to include the specific commits (7dd724e and referenced templates) that address the linked issue requirements.
Out of Scope Changes check ✅ Passed All changes are in-scope: JANS_SOURCE_VERSION and FLEX_SOURCE_VERSION updates in Dockerfiles align with syncing admin-ui resource scope mapping into OCI images per the linked issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cn-aui-scopes

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mo-auto mo-auto added comp-docker-admin-ui Component affected by issue or PR kind-dependencies Pull requests that update a dependency file labels Nov 18, 2025
@sonarqubecloud
Copy link

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7dd724e and 1639712.

📒 Files selected for processing (2)
  • docker-admin-ui/Dockerfile (2 hunks)
  • docker-flex-all-in-one/Dockerfile (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: devrimyatar
Repo: GluuFederation/flex PR: 2440
File: flex-linux-setup/flex_linux_setup/flex_setup.py:519-519
Timestamp: 2025-11-11T15:17:34.651Z
Learning: In flex-linux-setup/flex_linux_setup/flex_setup.py, the webhook LDIF (aui_webhook.ldif) should only be imported during fresh Admin UI installations, not during updates. The import is correctly guarded by the check `client_check_result['2001.'] == -1` which ensures it only runs when the Admin UI Web Client doesn't already exist. Docker update workflows differ from Linux update workflows in this regard.
🔇 Additional comments (1)
docker-admin-ui/Dockerfile (1)

25-25: Version pins align with PR objectives.

The FLEX_SOURCE_VERSION (line 47) is pinned to 7dd724efc02c20c9f22fac0eb90bbf9948202415, which matches the commit containing the resource scope mapping changes referenced in PR #2454. The templates cloned from FLEX_SETUP_DIR (lines 54–55) will reflect those updates, fulfilling the PR objective to sync resource scope mapping into the OCI image.

Also applies to: 47-47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-docker-admin-ui Component affected by issue or PR kind-dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(cloud-native): sync admin-ui resource scope mapping

3 participants